Skip to content

fix: throw .missingObjectId error when fetching #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2021
Merged

fix: throw .missingObjectId error when fetching #300

merged 2 commits into from
Dec 12, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Dec 12, 2021

New Pull Request Checklist

Issue Description

The SDK currently throws an .unknown error specifying the objectId is missing (when it's actually missing), but it can actually throw .missingObjectId from within the SDK.

Related issue: #n/a

Approach

Throw .missingObjectId in the above situation.

TODOs before merging

  • Add tests
  • Nit some of the docs
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 12, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #300 (23c0dba) into main (ebaaf12) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   83.66%   83.64%   -0.03%     
==========================================
  Files         105      105              
  Lines       11187    11190       +3     
==========================================
  Hits         9360     9360              
- Misses       1827     1830       +3     
Impacted Files Coverage Δ
...ParseSwift/Objects/ParseInstallation+combine.swift 92.94% <ø> (ø)
Sources/ParseSwift/API/API+Command.swift 83.77% <100.00%> (+0.47%) ⬆️
Sources/ParseSwift/Objects/ParseInstallation.swift 80.66% <100.00%> (+0.02%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 80.73% <100.00%> (+0.01%) ⬆️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 72.92% <0.00%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebaaf12...23c0dba. Read the comment docs.

@cbaker6 cbaker6 merged commit 5d2a370 into parse-community:main Dec 12, 2021
@cbaker6 cbaker6 deleted the nits branch December 12, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant