Skip to content

fix: don't lint DerivedData and remove force unwrapping #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2021
Merged

fix: don't lint DerivedData and remove force unwrapping #304

merged 1 commit into from
Dec 27, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Dec 27, 2021

New Pull Request Checklist

Issue Description

In latest version of Xcode, the linter sometimes tries to lint dummy files added by Xcode in the DerivedData folder, causing errors.

Related issue: #n/a

Approach

Make SwiftLint ignore the DerivedData folder.

TODOs before merging

  • Use optional binding instead of force unwrapping

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #304 (8761ea3) into main (931ae8f) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
- Coverage   83.73%   83.70%   -0.04%     
==========================================
  Files         105      105              
  Lines       11154    11154              
==========================================
- Hits         9340     9336       -4     
- Misses       1814     1818       +4     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/QueryWhere.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 72.92% <0.00%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931ae8f...8761ea3. Read the comment docs.

@cbaker6 cbaker6 merged commit 1636285 into parse-community:main Dec 27, 2021
@cbaker6 cbaker6 deleted the improveSwiftLint branch December 27, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant