Skip to content

feat: allow LiveQuery client to be set using defaultClient property #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2022
Merged

feat: allow LiveQuery client to be set using defaultClient property #360

merged 2 commits into from
May 17, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented May 17, 2022

New Pull Request Checklist

Issue Description

ParseLiveQuery had some extra methods to set/get the defaultClient.

Related issue: #n/a

Approach

  • Allow setting/getting the default LiveQuery client using only one property and deprecate others
  • Show compile time warnings and suggested updates when a developer uses deprecated code

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 17, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #360 (795a5c6) into main (6d9acd6) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   87.96%   87.91%   -0.05%     
==========================================
  Files         114      114              
  Lines       12198    12201       +3     
==========================================
- Hits        10730    10727       -3     
- Misses       1468     1474       +6     
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseSession.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParseAnalytics.swift 96.40% <ø> (-2.16%) ⬇️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 76.09% <100.00%> (-0.49%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 85.19% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9acd6...795a5c6. Read the comment docs.

@cbaker6 cbaker6 merged commit a82fd99 into parse-community:main May 17, 2022
@cbaker6 cbaker6 deleted the properties branch May 17, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant