Skip to content

docs: only use one target for SPI documentation #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

finestructure
Copy link
Contributor

@finestructure finestructure commented Jun 21, 2022

New Pull Request Checklist

Issue Description

Remove additional documentation targets which are platform flavours.

@cbaker6 Corey, I believe the intention here was to create four different doc sets here, one per platform. Unfortunately, that's not how our DocC generation (or DocC generation in general?) works.

The docset for all four targets is called parseswift and they end up simply overwriting each other in sequence. So currently you're hosting the last one, for watchOS. It's an outstanding item on my todo list to bring up with the DocC working group how multi-platform docsets are supposed to be generated and hosted side-by-side. I don't think there's anything we can do at the moment to address this :(

I'm not sure to what extent you have control over creating entirely separate doc targets which would allow you to ship separate sets per platform if they're materially different. If that's the case, would you like to open a discussion over in https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/discussions to see if this can be worked around somehow? I can go into more detail how the process works from our end which might allow experimentation on your end.

If there is one canonical or best suited set of docs to generate, it's best to only specify that for now!

Related issue: #n/a

Approach

TODOs before merging

  • Add changes to documentation (guides, repository pages, in-code descriptions)

Remove additional documentation targets which are platform flavours.

@cbaker6 Corey, I believe the intention here was to create four different doc sets here, one per platform. Unfortunately, that's not how our DocC generation (or DocC generation in general?) works.

The docset for all four targets is called `parseswift` and they end up simply overwriting each other in sequence. So currently you're hosting the last one, for watchOS. It's an outstanding item on my todo list to bring up with the DocC working group how multi-platform docsets are supposed to be generated and hosted side-by-side. I don't think there's anything we can do at the moment to address this :(

I'm not sure to what extent you have control over creating entirely separate doc targets which would allow you to ship separate sets per platform if they're materially different. If that's the case, would you like to open a discussion over in https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/discussions to see if this can be worked around somehow? I can go into more detail how the process works from our end which might allow experimentation on your end.

If there is one canonical or best suited set of docs to generate, it's best to only specify that for now!
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 21, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #374 (aafe9aa) into main (3b3b839) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   89.12%   89.11%   -0.02%     
==========================================
  Files         140      140              
  Lines       13546    13546              
==========================================
- Hits        12073    12071       -2     
- Misses       1473     1475       +2     
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseUser.swift 86.03% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b3b839...aafe9aa. Read the comment docs.

@cbaker6
Copy link
Contributor

cbaker6 commented Jun 21, 2022

I believe the intention here was to create four different doc sets here, one per platform. Unfortunately, that's not how our DocC generation (or DocC generation in general?) works.

Hi Sven, thanks for the fix. I was testing this based on the SPI blog with the intent to see what happens.

I'm not sure to what extent you have control over creating entirely separate doc targets which would allow you to ship separate sets per platform if they're materially different.

The docs for Pare-Swift are essentially the same, so we can go with one target.

@cbaker6 cbaker6 changed the title Update .spi.yml docs: only use one target for SPI documentation Jun 21, 2022
@cbaker6 cbaker6 merged commit 36f9d1a into parse-community:main Jun 21, 2022
@finestructure finestructure deleted the patch-1 branch June 21, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants