Workaround for empty main bundle identifier on Linux #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dentifier instead.
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 77.95% 77.98% +0.02%
==========================================
Files 51 51
Lines 4578 4584 +6
==========================================
+ Hits 3569 3575 +6
Misses 1009 1009
Continue to review full report at Codecov.
|
cbaker6
reviewed
Jan 24, 2021
|
@jt9897253 thanks for your contribution! Does You can uncomment these lines in the workflow for now Parse-Swift/.github/workflows/ci.yml Lines 99 to 100 in 80802c5 You can comment them back out after we see the results as Linux will still have some failures when comparing optionals in the current test cases. |
Unfortunately, not. Here's the full log for I do not yet understand why it is "Unable to sync with parse-server".
Done |
I suspect this might actually be okay. The custom Let us know if/when you use a ParseFile in your actual development and if it works. |
|
Can you comment back out the Linux tests and we can merge your PR. |
cbaker6
approved these changes
Jan 25, 2021
I've tested downloading a parse file, the resulting path looks like
and contains the correct data. Although If this really was it, adding parse file support to Linux was way simpler than anticipated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, Bundle.main.bundleIdentifier is nil.
This commit creates a custom bundle identifier instead.
With this change, tests for
ParseFileManagerseem to pass on Linux:I put up this PR for discussion of what the the custom value for
Bundle.main.bundleIdentifiershould be, on Linux. Is the proposed solution unique enough?As an example, with this change, the test
ParseFileManagerTests.testWriteDatawould write tofile:///$HOME/.local/share/parse/com.github.parse-community.parse-swift.applicationId/test.txton Linux.I do not exactly understand how this path is composed but it looks acceptable for me, as it is located in the user's home directory.
This is a follow up to the discussion from #63