Skip to content

Add pull responses to Subscription for publishable VM #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 27, 2021
Merged

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 26, 2021

This PR adds the query pull methods such as find, first, count, and aggregate to Subscription so they can be accessed in a SwiftUI view model next to LiveQuery subscribe, event, and unsubscribe.

The minimizes the need for a developer to have to start from scratch when creating their own view model and gives them the power of LiveQuery alongside traditional Parse queries out-of-the-box.

The PR is non-breaking...

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #71 (90a2699) into main (d03861f) will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   78.11%   78.49%   +0.38%     
==========================================
  Files          52       52              
  Lines        4620     4693      +73     
==========================================
+ Hits         3609     3684      +75     
+ Misses       1011     1009       -2     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/Query.swift 90.85% <ø> (+0.27%) ⬆️
Sources/ParseSwift/LiveQuery/Subscription.swift 85.93% <100.00%> (+18.66%) ⬆️
Sources/ParseSwift/Objects/ParseObject.swift 76.60% <0.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d03861f...90a2699. Read the comment docs.

@cbaker6 cbaker6 requested a review from TomWFox January 27, 2021 00:05
@cbaker6
Copy link
Contributor Author

cbaker6 commented Jan 27, 2021

@TomWFox can look at the docs?

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cbaker6 cbaker6 merged commit 48a871e into main Jan 27, 2021
@cbaker6 cbaker6 deleted the swiftUI branch January 27, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants