-
-
Notifications
You must be signed in to change notification settings - Fork 132
Conversation
@dstarke I built upon your PR and fixed the issues for the podfile. I however am not really happy to rely on a forked version of SocketRocket for the pods. |
@dstarke I decided to go the extreme way, use Starscream instead of SR. Seems that Starscream is well supported and maintained. What do you think? |
b876f6d
to
c70cf0f
Compare
@flovilmart That seems like a reasonable choice. I had to patch SocketRocket even further to produce a releasable app. |
Uhm alright. Can you update me if it works / integrates well with Carthage? (and is reasonably stable) |
I think it works. I've been able to build it and run successfully via Carthage (I had to modify my project to remove the SocketRocket framework and add the Starscream framework for the copy-frameworks step, so it isn't a drop-in replacement). Since my project uses a fork which also has the fix-object-decoding branch merged into it, and I have code that doesn't work without that, I have a little more work to do before I can see how reliable it is in an actual product. |
87b80e8
to
398e230
Compare
Yeah that would be expected for a carthage setup, I'll bump the tag to a major so no-one is surprised.
I merge the fix object decoding to master and rebased that branch as well. |
Thanks! I have my manually merged version running now, and it seems to be working. |
SO that's great news then! let me know if there is anything broken there |
- Uses tagged fork 0.6.0 for compatibility with podspec - fork is located on parse-server modules - fork is published on CocoaPods under SocketRocketParseLiveQuery
5b3e6cc
to
a93dc83
Compare
@dstarke I just tested with my setup with Cocoapods, I didn't find anything crazy or weird happening. Let's merge that and release. |
No description provided.