Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

Carthage support #95

Merged
merged 11 commits into from
Feb 24, 2017
Merged

Carthage support #95

merged 11 commits into from
Feb 24, 2017

Conversation

flovilmart
Copy link
Contributor

No description provided.

@flovilmart
Copy link
Contributor Author

@dstarke I built upon your PR and fixed the issues for the podfile. I however am not really happy to rely on a forked version of SocketRocket for the pods.

@flovilmart
Copy link
Contributor Author

@dstarke I decided to go the extreme way, use Starscream instead of SR. Seems that Starscream is well supported and maintained. What do you think?

@dstarke
Copy link

dstarke commented Feb 23, 2017

@flovilmart That seems like a reasonable choice. I had to patch SocketRocket even further to produce a releasable app.

@flovilmart
Copy link
Contributor Author

Uhm alright. Can you update me if it works / integrates well with Carthage? (and is reasonably stable)

@dstarke
Copy link

dstarke commented Feb 23, 2017

I think it works. I've been able to build it and run successfully via Carthage (I had to modify my project to remove the SocketRocket framework and add the Starscream framework for the copy-frameworks step, so it isn't a drop-in replacement).

Since my project uses a fork which also has the fix-object-decoding branch merged into it, and I have code that doesn't work without that, I have a little more work to do before I can see how reliable it is in an actual product.

@flovilmart
Copy link
Contributor Author

(I had to modify my project to remove the SocketRocket framework

Yeah that would be expected for a carthage setup, I'll bump the tag to a major so no-one is surprised.

Since my project uses a fork which also has the fix-object-decoding branch

I merge the fix object decoding to master and rebased that branch as well.

@dstarke
Copy link

dstarke commented Feb 23, 2017

Thanks! I have my manually merged version running now, and it seems to be working.

@flovilmart
Copy link
Contributor Author

SO that's great news then! let me know if there is anything broken there

@flovilmart
Copy link
Contributor Author

@dstarke I just tested with my setup with Cocoapods, I didn't find anything crazy or weird happening. Let's merge that and release.

@flovilmart flovilmart merged commit 530452b into master Feb 24, 2017
@flovilmart flovilmart deleted the carthage-support branch February 24, 2017 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants