Added requirement to use ignoreAcls() when retrieving data from datastore #541
Conversation
…tore which is configured with Role based ACLs
|
I've discovered that calling ignoreAcls() on a query then makes that query unusable for network calls, raising this exception:
This is problematic if you want to use a query to load from datastore, then later use the same query to load from network. I can't see any method to "undo ignoreAcls", so you would have to reconstruct the query (ugh). I think a note about this should be added, the problem is I don't exactly know when you really NEED to call ignoreAcls for a data store query so unsure what the advice should be. It seemed to work fine for some of my classes, and not others, and I can't figure out what difference in Roles is responsible (they are all the same as far as I can determine). So now I'm not sure what to do... do we need to revert this change? Or perhaps the documentation amendment needs to be something along the lines of "if you experience problems loading results from the local data store for classes utilising role based ACLs you MAY need to call applyAcls..."? |
|
You should probably use a factory method that generate you that query, and then run that query on the localDatastore and network independentlyx |
|
Yeah, this is what I've just implemented in my project. It's quite ugly though, so now think that ignoreAcls should only be used if you need to. Should I create a new pull request to make this clearer? PS also found this on SO, confirms the same issue and suggests an alternative solution (setting ACLs when pinning): |
|
Yep go ahead! Anything that can make it clearer is always welcome! |
|
Made another pull request, it said it couldn't automatically merge... is that okay? I've got a bit of Git learning to do... |
|
@jamesncl it's all good. The PR said it couldn't merge because the branch used for the PR was out of sync with the target branch. I just had to fix the conflicts and it's all good! Thanks for the PR's! It's well appreciated! |
Can affect ParseObjects configured with Role based ACLs. Related to issue #428 in Android SDK. This note is present in iOS documentation only, but also affects Android. Note that applying query.ignoreAcls() then makes the query unusable for network queries (generates exception "ignoreAcls cannot be mixed with network queries").