-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(Database Browser): Select all objects #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Database Browser): Select all objects #1219
Conversation
Allows users to select all objects. This is only enabled when the lazy loading has loaded all possible objects, since we don't have a way to select all objects based on a query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like we talked, I think that a better approach would be selecting what is currently visible.
Changes done! |
@douglasmuraoka it worked pretty good to me but I think we need just one more small fix. If I have, for example, 400 rows, select all (it will select the first 200 ones - because they are the visible ones), then delete these rows, everything works fine and the dashboard count shows me that I have 200 rows left, but they don't show up in the table. I think we should manage to load more rows every time that a delete operation happens. Can you do this? |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! LGTM!
Allows users to select all visible objects. If lazy loading fetches more data, the select all checkbox is unset.