Skip to content

feat(Database Browser): Select all objects #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

douglasmuraoka
Copy link
Contributor

@douglasmuraoka douglasmuraoka commented Aug 13, 2019

Allows users to select all visible objects. If lazy loading fetches more data, the select all checkbox is unset.

Allows users to select all objects. This is only enabled when the lazy loading has loaded all possible objects, since we don't have a way to select all objects based on a query.
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like we talked, I think that a better approach would be selecting what is currently visible.

@douglasmuraoka
Copy link
Contributor Author

Like we talked, I think that a better approach would be selecting what is currently visible.

Changes done!

@davimacedo
Copy link
Member

@douglasmuraoka it worked pretty good to me but I think we need just one more small fix. If I have, for example, 400 rows, select all (it will select the first 200 ones - because they are the visible ones), then delete these rows, everything works fine and the dashboard count shows me that I have 200 rows left, but they don't show up in the table. I think we should manage to load more rows every time that a delete operation happens. Can you do this?

@douglasmuraoka
Copy link
Contributor Author

@douglasmuraoka it worked pretty good to me but I think we need just one more small fix. If I have, for example, 400 rows, select all (it will select the first 200 ones - because they are the visible ones), then delete these rows, everything works fine and the dashboard count shows me that I have 200 rows left, but they don't show up in the table. I think we should manage to load more rows every time that a delete operation happens. Can you do this?

Done!
Whenever the user deletes objects and the remaining objects on the table are lesser than the maximum allowed objects, we fetch more data.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM!

@davimacedo davimacedo merged commit b377452 into parse-community:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants