Skip to content

fix: Update base config to work with sass-loader 8.x #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2019
Merged

fix: Update base config to work with sass-loader 8.x #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
"parse-dashboard": "./bin/parse-dashboard"
},
"engines": {
"node": ">=4.3"
"node": ">=8.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some dependencies that require at least node 8.x, as Parse-Server. Besides that, sass-loader announced a breaking change in the changelog about minimum required node version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is pretty reasonable to require at least node >= 8.9 as in Parse Server. @dplewis @acinader thoughts?

Copy link
Contributor

@acinader acinader Aug 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm good with it. Node 8 is at 8.16 and it goes out of maintenance in a few months at which point I think we set the minimum at 10 and should be testing everything against 12 too!

More broadly (and to invite criticism), I think that when considering node versions for all of our node repositories (and parse-dashboard in particular), we should not bend over backward to support obsolete versions like early node 8 versions.

Users don't have to upgrade to newer versions of parse if they are unwilling to keep up with dependencies.

I suspect that this is a non-issue. Would we then want to make the next release 2.0.0? I think to comply with semantic versioning we should??? For some reason, I'm stingy with those version numbers ;).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Let's go to Parse Dashboard 2.0 then.

},
"main": "Parse-Dashboard/app.js",
"jest": {
Expand Down
9 changes: 8 additions & 1 deletion webpack/base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,14 @@ module.exports = {
importLoaders: 2
},
},
"sass-loader?includePaths[]=" + encodeURIComponent(path.resolve(__dirname, '../src'))
{
loader: 'sass-loader',
options: {
sassOptions: {
includePaths: [path.resolve(__dirname, '../src')]
}
}
}
]
}, {
test: /\.css$/,
Expand Down