Fetch class counts using Parse Query #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.props.schema.data.get('classes').forEach((_, className) => { | ||
| this.context.currentApp.getClassCount(className) | ||
| .then(count => this.setState({ counts: { [className]: count, ...this.state.counts } })); | ||
| }) |
There was a problem hiding this comment.
;
Should be fine in the short term. For any of these requests where a batch doesn't exist we may consider having the dashboard node server make the request. But ideally we go straight to the api server without any application logic.
There was a problem hiding this comment.
I would rather not add any logic to the node thing that serves the dashboard. Adding logic to the server would be reasonable I think. But thats a debate for another time.
drew-gross
force-pushed
the
classCounts
branch
from
528668b to
fd73509
Compare
drew-gross
added a commit
that referenced
this pull request
Feb 27, 2016
Fetch class counts using Parse Query
|
@drew-gross updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse Server doesn't have the bulk collection info endpoints, so we can't batch the count queries, unfortunately.