Skip to content

🚧 Splits express app from express server #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2016

Conversation

flovilmart
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link

By analyzing the blame information on this pull request, we identified @drew-gross, @hallucinogen and @andresgarza to be potential reviewers.

@flovilmart
Copy link
Contributor Author

Ahah :) if you mount the app somewhere else but / it won't work... but that's not breaking

@drew-gross
Copy link
Contributor

Yeah I figured the construction thing meant that this was some supporting work that will help implement other stuff later. As long as it's not breaking, it's fine to merge.

@flovilmart
Copy link
Contributor Author

Supporting a relative mount path will be problematic as the bundle expects the config on /, as well as other resources

@mnoble
Copy link
Contributor

mnoble commented Apr 1, 2016

fwiw, this broke Dashboard for me. allowInsecureHTTP isn't defined (or accessible) from app.js since it's a flag parsed via commander in index.js, but used at https://github.com/ParsePlatform/parse-dashboard/blob/master/Parse-Dashboard/app.js#L43.

@flovilmart
Copy link
Contributor Author

oops! let's fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants