Remove gatekeeper #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,7 +66,7 @@ const FIELD_TYPE = { | |||
| 'Request Type' : 'String', | |||
| 'Class' : 'String', | |||
| 'Event Name' : 'String', | |||
| 'Dimensions' : check_gatekeeper('explorer_json_scalar') ? 'JSON' : 'String', | |||
| 'Dimensions' : false ? 'JSON' : 'String', | |||
There was a problem hiding this comment.
hmm why not just have 'Dimensions' : 'String' ?
|
The idea is that in-progress features don't have to stop being in-progress. We can't just use gatekeepers anymore, but I want to have some sort of feature flag. Going into the source and changing a |
|
got it - maybe add some comment/tag to keep track of it and grepability |
|
sure will do |
drew-gross
force-pushed
the
remove-gks
branch
from
7d67762 to
e575600
Compare
|
@drew-gross updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.