Skip to content

fix: file upload dialog in data browser shows multiple times #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2022
Merged

fix: file upload dialog in data browser shows multiple times #2276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ed9e6c
fix: fileUpload dialog shows multiple times on modal view
dblythy Sep 19, 2022
864ea62
Merge branch 'alpha' into file-upload
mtrezza Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/dashboard/Data/Browser/EditRowDialog.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default class EditRowDialog extends React.Component {
const { currentObject, openObjectPickers, expandedTextAreas } = this.initializeState(
selectedObject
);
this.state = { currentObject, openObjectPickers, expandedTextAreas, showFileEditor: false };
this.state = { currentObject, openObjectPickers, expandedTextAreas, showFileEditor: null };

this.updateCurrentObject = this.updateCurrentObject.bind(this);
this.handleChange = this.handleChange.bind(this);
Expand Down Expand Up @@ -224,15 +224,15 @@ export default class EditRowDialog extends React.Component {
this.setState({ expandedTextAreas });
}

openFileEditor() {
openFileEditor(column) {
this.setState({
showFileEditor: true
showFileEditor: column
});
}

hideFileEditor() {
this.setState({
showFileEditor: false
showFileEditor: null
});
}

Expand Down Expand Up @@ -358,9 +358,9 @@ export default class EditRowDialog extends React.Component {
<div style={{ cursor: 'pointer' }}>
<Pill
value={file ? 'Change file' : 'Select file'}
onClick={() => this.openFileEditor()}
onClick={() => this.openFileEditor(name)}
/>
{this.state.showFileEditor && (
{this.state.showFileEditor === name && (
<FileEditor
value={file}
onCancel={this.hideFileEditor}
Expand Down