Skip to content

Implement basic auth #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2016
Merged

Implement basic auth #27

merged 2 commits into from
Mar 3, 2016

Conversation

drew-gross
Copy link
Contributor

Tried to make this as hard to abuse as possible. Username, password, and HTTPS are all required if you aren't running on localhost.

}
//Based on advice from Doug Wilson here:
//https://github.com/expressjs/express/issues/2518
var requestIsLocal =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: ===

drew-gross added a commit that referenced this pull request Mar 3, 2016
@drew-gross drew-gross merged commit 7501462 into master Mar 3, 2016
@facebook-github-bot
Copy link

@drew-gross updated the pull request.

@peterdotjs peterdotjs deleted the basic-auth branch March 9, 2016 06:48
douglasmuraoka pushed a commit that referenced this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants