-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
ci: Fix Node engine version check failing #2847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix Node engine version check failing #2847
Conversation
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. |
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe CI workflow is updated to separate the installation of production dependencies from the removal of development dependencies. A new shell script is introduced to uninstall all dev dependencies except specified exclusions, and the workflow is adjusted to use this script after installing production dependencies. Changes
Sequence Diagram(s)sequenceDiagram
participant CI Workflow
participant npm
participant uninstallDevDeps.sh
CI Workflow->>npm: npm ci --ignore-scripts (Install prod dependencies)
CI Workflow->>uninstallDevDeps.sh: ./ci/uninstallDevDeps.sh @actions/core
uninstallDevDeps.sh->>npm: npm uninstall <devDependencies except @actions/core>
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
New Pull Request Checklist
Issue Description
Node engine version check failing because it considers dev dependencies as well.
Approach
Exclude dev dependencies from check.
Summary by CodeRabbit