Added SSL Support to Dashboard #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @drew-gross, @gimdongwoo and @hpello to be potential reviewers. |
ghost
added
|
Awesome, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added SSL/HTTPS support to the Dashboard Express app via two new command line options. An example command for SSL is:
$ parse-dashboard --config ~/dash-config.json --sslKey /etc/letsencrypt/live/domain.com/privkey.pem --sslCert /etc/letsencrypt/live/domain.com/cert.pemThis will load app details from the config file and load current SSL keys as generated from letsencrypt.
Some basic info came from #204.
Let me know if I'm missing anything, or if you'd like me to add details to the README file as well.