Skip to content

Allow trust proxy if allowInsecureHTTP #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2016

Conversation

yongjhih
Copy link
Contributor

@yongjhih yongjhih commented Apr 30, 2016

app.enable('trust proxy'); when you are running the dashboard behind an HTTPS load balancer or proxy.

@ghost
Copy link

ghost commented Apr 30, 2016

By analyzing the blame information on this pull request, we identified @drew-gross, @Vortec4800 and @gimdongwoo to be potential reviewers.

@drew-gross
Copy link
Contributor

We actually have plans to make the allowInsecureHTTP option actually just set trust proxy, instead of an approach like this. Either way, we definitely don't want to trust proxy by default, as we don't always know if there is a trusted proxy.

@yongjhih yongjhih closed this May 6, 2016
@yongjhih yongjhih reopened this May 6, 2016
@yongjhih yongjhih changed the title Allow trust proxy Allow trust proxy if allowInsecureHTTP May 6, 2016
@yongjhih
Copy link
Contributor Author

yongjhih commented May 6, 2016

Ok, I see. Thanks for your explaining. I've updated patch.

@ghost
Copy link

ghost commented May 6, 2016

@yongjhih updated the pull request.

@drew-gross
Copy link
Contributor

Awesome! Thanks :)

@drew-gross drew-gross merged commit 45b2b33 into parse-community:master May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants