Skip to content

Default config that includes no apps #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2016
Merged

Default config that includes no apps #35

merged 3 commits into from
Mar 4, 2016

Conversation

drew-gross
Copy link
Contributor

No description provided.

@@ -3,6 +3,8 @@ We want to make contributing to this project as easy and transparent as
possible.

## Our Development Process
The standard installation method also clones the git repository, so you can start making and submitting changes right away. For convenience, you can use `git update-index --assume-unchanged Parse-Dashboard/parse-dashboard-config.json` to ignore your own personal configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about keeping the .gitignore as is and leave this part out. We'll add the default to the repo but avoid any chance of someone attempting to PR it in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitignore doesn't ignore tracked filed, so that won't work :(

I could add a step to npm install that does the assume unchanged thing, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah I was afraid that was the case :(

+1 for adding in a postInstall script approach or for adding explicit instructions on where to put the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@facebook-github-bot
Copy link

@drew-gross updated the pull request.

peterdotjs added a commit that referenced this pull request Mar 4, 2016
Default config that includes no apps
@peterdotjs peterdotjs merged commit 00229e3 into master Mar 4, 2016
@peterdotjs peterdotjs deleted the default-config branch March 9, 2016 06:48
douglasmuraoka pushed a commit that referenced this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants