Add point spliting and auto focusing to the GeoPointEditor #373
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @drew-gross to be a potential reviewer. |
ghost
added
|
Cool! I think this is a really neat idea. We aren't super strict about code style, so I'm going to merge this, but also leave some comments, which you could address in a new PR if you feel like it. |
| var values = value.split(","); | ||
|
|
||
| if (values.length == 2) { | ||
| values = values.map(function(val) { |
There was a problem hiding this comment.
We tend to prefer fat arrow functions: values = values.map(val => val.trim())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for certain comma (,) related features to the GeoPointEditor.
Fill Via Paste
Allows you to paste a coordinate "23.45, 10.00" into the latitude field and it will auto populate.
Auto Advance
Allows you to paste an incomplete coordinate "23.45, " into the latitude field and it will auto advance to longitude. If you type in "23.45," it will also auto advance on the ,.
This is my first pull request, so if code quality is not up to par, or I did something wrong in this process please tell me.