Sorting applications by name in the dashboard, #415 #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @drew-gross to be a potential reviewer. |
ghost
added
|
LGTM. I might have put this in the place where the apps are rendered, but this works too. |
|
Looking a bit more at this and there is actually some sorting-code in https://github.com/ParsePlatform/parse-dashboard/blob/master/src/dashboard/Apps/AppsIndex.react.js#L137. However, createdAt seems to be null everywhere, so that doesnt have any effect. I'll have a look at refining my code and possibly adding other sorting options. (User count, Installation count or appName?) |
|
Yeah createdAt only existed on dashboard.parse.com, in this Parse Dashboard we don't know when apps were created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always sorts before returning apps() - should probably live somewhere else but I'm unable to find a suitable location for it. Solves #415