Update parse SDK to 1.9.1. #620
Conversation
|
By analyzing the blame information on this pull request, we identified @JeremyPlease, @flovilmart and @drew-gross to be potential reviewers. |
|
Any updates on this one @jacob-meacham ? |
|
We've been using it in staging and haven't seen any issues - however, this issue was wrapped up in another issue I was having trying to wrangle binary uploads/downloads through AWS API Gateway (we've since moved away from proxying through APIG). I believe that this PR is still required, but given the other issue I was having, it might not be. |
|
This will also fix #618. |
src/dashboard/Dashboard.js
Outdated
| }).then(function() { | ||
| Array.prototype.slice.call(arguments).forEach(app => { | ||
| }).then(function(resolvedApps) { | ||
| Array.prototype.slice.call(resolvedApps).forEach(app => { |
There was a problem hiding this comment.
Is resolvedApps is an array, then no need to call Array.prototype.slice on it.
jacob-meacham
force-pushed
the
feature/update-parse-sdk
branch
from
7991934 to
422e050
Compare
|
@jacob-meacham updated the pull request - view changes |
|
@flovilmart Sorry, I didn't see that this was waiting on changes from me! |
|
LGTM! |
The specific issue this fixes for us is parse-community/Parse-SDK-JS#311.
I've only done smoke testing of this fix, but will be deploying it to our staging instance today and will update if I run into any issues.