Skip to content

Don’t call unsupported endpoints in Parse Server #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

natanrolnik
Copy link
Contributor

@natanrolnik natanrolnik commented Feb 11, 2017

Also, this PR fixes 2 React warnings related to not setting a key in a few components (See Logs.react.js and Jobs.react.js)

Fixes #295

Copy link
Contributor

@JeremyPlease JeremyPlease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit :)

Otherwise, looks good to me.

@@ -119,8 +119,8 @@ export default class Jobs extends TableView {

renderRow(data) {
if (this.props.params.section === 'all') {
return (
<tr key={data.objectId}>
return (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should keep indentation inside if statement.

Also, this commit fixes 2 React warnings related to not setting a key in a few components (See Logs.react.js and Jobs.react.js)
@natanrolnik natanrolnik force-pushed the comment-unsupported-server-features branch from b1fd892 to 5651292 Compare February 12, 2017 18:20
@facebook-github-bot
Copy link

@natanrolnik updated the pull request - view changes

@natanrolnik
Copy link
Contributor Author

@JeremyPlease good catch! Done.

Copy link
Contributor

@steven-supersolid steven-supersolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natanrolnik natanrolnik merged commit fd121bd into parse-community:master Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 domain.com/parse/releases/latest
4 participants