Skip to content

Converted UTC date to local time #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

imMatt
Copy link

@imMatt imMatt commented Jul 23, 2017

For our development environment we wanted dates listed in the local time instead of UTC, unsure if anyone else would find it useful so submitting here.

It should most likely be configuration, or enabled by a flag but I'm not 100% sure on the best practice for doing that within the project is, so if anyone could give some pointers it'd be much appreciated.

@imMatt imMatt closed this Jul 23, 2017
@natanrolnik
Copy link
Contributor

Hey, @Matt-Allen44!
I think that we should be able to pass this from the config.json file, or as a parameter when starting with the command line tool.
What do you think?

@imMatt
Copy link
Author

imMatt commented Jul 25, 2017

I was having a look into doing it as a command line flag, but I wasn't sure what the best practice for retrieving it from within BrowserCell was, as I had a look around and pretty much all of the flags seemed to be handled on startup with the main JS file.

Feel as if parameter and config would be the best way to go.

@imMatt imMatt reopened this Jul 25, 2017
@adolfdsilva
Copy link

Hi even we require this feature.. can we merge this?

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state:wont-fix Won’t be fixed with a clearly stated reason label Jan 10, 2019
@stale stale bot closed this Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:wont-fix Won’t be fixed with a clearly stated reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants