Adds interface for localized push notifications #769
Conversation
|
@acinader can you have a look on this one? |
README.md
Outdated
| @@ -282,6 +282,26 @@ When `user1` logs in, he/she will be able to manage `myAppId1` and `myAppId2` fr | |||
|
|
|||
| When *`user2`* logs in, he/she will only be able to manage *`myAppId1`* from the dashboard. | |||
|
|
|||
| ## Configuring Localized Push Notifications | |||
|
|
|||
| With the latest version of the dashboard, it is possible to send localized messages for push notifications. | |||
There was a problem hiding this comment.
make dashboard a link. for bonus points make push notifications a link to doc too ;)
src/dashboard/Push/PushNew.react.js
Outdated
| return false; | ||
| } | ||
| return true; | ||
| }); |
There was a problem hiding this comment.
.filter(locale => !(locale === '' || locale === undefined))
(since you kept the one in the dashboard ;))
src/dashboard/Push/PushNew.react.js
Outdated
| const available = this.context.currentApp.isLocalizationAvailable(); | ||
| if (available) { | ||
| const locales = this.context.currentApp.fetchPushLocales(); | ||
| let filteredLocales = locales.filter((locale) => { |
There was a problem hiding this comment.
prefer const? or am I missing where it gets edited?
src/dashboard/Push/PushNew.react.js
Outdated
| @@ -202,6 +195,13 @@ export default class PushNew extends DashboardView { | |||
| payload.badge = "Increment"; | |||
| } | |||
|
|
|||
| // Gather the translations, and inject into the payload | |||
| Object.keys(changes).forEach((key) => { | |||
| if (key.indexOf('translation[') === 0) { | |||
There was a problem hiding this comment.
a comment showing the string we're operating on here please.
src/lib/ParseApp.js
Outdated
| @@ -404,13 +406,11 @@ export default class ParseApp { | |||
| } | |||
|
|
|||
| isLocalizationAvailable() { | |||
| let path = '/apps/' + this.slug + '/is_localization_available'; | |||
| return AJAX.abortableGet(path); | |||
| return this.serverInfo.features.push.localization === true; | |||
There was a problem hiding this comment.
as written, this is exactly the same as just
return this.serverInfo.features.push.localization
it's like boolean day or something ;)
if this.serverInfo.features.push.localization might just be truthy instead of actual true then === wont work and you'd want return !!this.serverInfo.features.push.localization instead?
There was a problem hiding this comment.
you are right :)
flovilmart
force-pushed
the
localized-push
branch
from
eb926ea to
768341d
Compare
- This is somewhat different from parse.com and probably more efficient
flovilmart
force-pushed
the
localized-push
branch
from
768341d to
422a009
Compare
|
@acinader adressed the nits + merge conflicts. |
src/dashboard/Push/PushNew.react.js
Outdated
| // Gather the translations, and inject into the payload | ||
| Object.keys(changes).forEach((key) => { | ||
| // translations are stored as `tranlation[lang]` strings as keys, | ||
| // this is why we slice it this way |
There was a problem hiding this comment.
Clear. thanks...just thinking out loud, not asking for change....
const needle = 'translation[';
if (key.indexOf(needle) === 0) {
const locale = key.slice(needle.length, key.length - 1);
There was a problem hiding this comment.
Eheh, if you need a comment, many others may need a comment. it's better with it than without.
|
Looks like I broke master by merging #709 |
* Adds interface for localized push notifications - This is somewhat different from parse.com and probably more efficient * Fix lint issues * nits * nit * fixes compile issues * cache node_modules
See also: parse-community/parse-server#4130