Fixes missing supportedPushLocales in #811 #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
approved these changes
Nov 15, 2017
|
@flovilmart you mean this? |
|
Yessir! |
|
Cool, we should be good the if there's nothing else that comes to mind? |
|
I meant as an alert inside the section, explaining how to set it up. |
|
Ohhhh, you mean as an actual log entry if the localizations are found not to be set? Or do you mean something else still. |
…on on how to correct it.
|
@flovilmart Just bumping here. Added a console warning to indicate in the logs if push localization is missing altogether, along with a link to the relevant section in the docs. |
flovilmart
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly added
supportedPushLocalescauses the Push section of the dashboard to break if it is not present. This adds a one-line check to set an empty array if push locales are not set. This does not remove the option to set a push locale however, it just provides no options as can be seen below.