Skip to content

make sure we always send apns-expiration as integer number #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2018
Merged

make sure we always send apns-expiration as integer number #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b7e1a1
make sure we always send integer as apns-expiration
mman Feb 9, 2018
2b611a5
make sure we always send apns-expiration parameter as integer
mman Feb 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions spec/APNS.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ describe('APNS', () => {
'key': 'value',
'keyAgain': 'valueAgain'
});
expect(notification.expiry).toEqual(expirationTime / 1000);
expect(notification.expiry).toEqual(Math.round(expirationTime / 1000));
expect(notification.collapseId).toEqual(collapseId);
done();
});
Expand All @@ -208,7 +208,7 @@ describe('APNS', () => {

let notification = APNS._generateNotification(data, { expirationTime: expirationTime, collapseId: collapseId });

expect(notification.expiry).toEqual(expirationTime / 1000);
expect(notification.expiry).toEqual(Math.round(expirationTime / 1000));
expect(notification.collapseId).toEqual(collapseId);

let stringifiedJSON = notification.compile();
Expand Down Expand Up @@ -307,7 +307,7 @@ describe('APNS', () => {
let calledArgs = provider.send.calls.first().args;
let notification = calledArgs[0];
expect(notification.aps.alert).toEqual(data.data.alert);
expect(notification.expiry).toEqual(data['expiration_time'] / 1000);
expect(notification.expiry).toEqual(Math.round(data['expiration_time'] / 1000));
expect(notification.collapseId).toEqual(data['collapse_id']);
let apnDevices = calledArgs[1];
expect(apnDevices.length).toEqual(4);
Expand Down Expand Up @@ -383,7 +383,7 @@ describe('APNS', () => {
let calledArgs = provider.send.calls.first().args;
let notification = calledArgs[0];
expect(notification.aps.alert).toEqual(data.data.alert);
expect(notification.expiry).toEqual(data['expiration_time'] / 1000);
expect(notification.expiry).toEqual(Math.round(data['expiration_time'] / 1000));
expect(notification.collapseId).toEqual(data['collapse_id']);
let apnDevices = calledArgs[1];
expect(apnDevices.length).toBe(3);
Expand All @@ -392,7 +392,7 @@ describe('APNS', () => {
calledArgs = providerDev.send.calls.first().args;
notification = calledArgs[0];
expect(notification.aps.alert).toEqual(data.data.alert);
expect(notification.expiry).toEqual(data['expiration_time'] / 1000);
expect(notification.expiry).toEqual(Math.round(data['expiration_time'] / 1000));
expect(notification.collapseId).toEqual(data['collapse_id']);
apnDevices = calledArgs[1];
expect(apnDevices.length).toBe(2);
Expand Down
2 changes: 1 addition & 1 deletion src/APNS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ export class APNS {
notification.payload = payload;

notification.topic = headers.topic;
notification.expiry = headers.expirationTime / 1000;
notification.expiry = Math.round(headers.expirationTime / 1000);
notification.collapseId = headers.collapseId;
return notification;
}
Expand Down