Add support for passing collapse-id to APNS #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 249 252 +3
=====================================
+ Hits 249 252 +3
Continue to review full report at Codecov.
|
|
Thanks for the PR. Can you provide links to the docs from the APN lib as well as apple's so I can doublecheck if it's implemented as expected? |
flovilmart
suggested changes
May 8, 2017
src/APNS.js
Outdated
| @@ -95,7 +96,8 @@ export class APNS { | |||
| continue; | |||
| } | |||
|
|
|||
| let notification = APNS._generateNotification(coreData, expirationTime, appIdentifier); | |||
| let headers = { expirationTime: expirationTime, appIdentifier: appIdentifier, collapseId: collapseId } | |||
There was a problem hiding this comment.
the appIdentifier header should be renamed topic
|
Thanks for the docs! Very helpful :) Just one small nit. |
|
Looking great! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for adding
apns-collapse-idto enable collapsing of pushes just like theapns-expiration.I changed the method signature for
APNS_generateNotificationfromAPNS._generateNotification(data, expirationDate)toAPNS._generateNotification(data, headers)making it easier to add more header properties in the future.headers
The headers parameter is a JS object with the following supported properties:
Don't hesitate to feedback on the code as JS isn't my "native" language :)