Skip to content

Update APNS.js #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2017
Merged

Update APNS.js #89

merged 3 commits into from
Jul 23, 2017

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Jul 15, 2017

Fixes #88

@codecov
Copy link

codecov bot commented Jul 15, 2017

Codecov Report

Merging #89 into master will increase coverage by 0.78%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #89      +/-   ##
========================================
+ Coverage   99.21%   100%   +0.78%     
========================================
  Files           5      5              
  Lines         254    254              
========================================
+ Hits          252    254       +2     
+ Misses          2      0       -2
Impacted Files Coverage Δ
src/APNS.js 100% <100%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af48cbc...71a449b. Read the comment docs.

Copy link

@theill theill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the contract in 'apn' module and this is the correct change required.

@flovilmart
Copy link
Contributor Author

Thanks @theill !

@flovilmart flovilmart merged commit 1f1f9ab into master Jul 23, 2017
@flovilmart flovilmart deleted the fix-88 branch July 23, 2017 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants