Skip to content

Fixed bug whereby region was ignored. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Fixed bug whereby region was ignored. #1

merged 1 commit into from
Mar 31, 2016

Conversation

jsuresh
Copy link
Contributor

@jsuresh jsuresh commented Mar 30, 2016

I couldn't connect to a sydney S3 bucket, and triaged the issue to the fix below. This is in line with what the doco seems to say as well.

http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Config.html

I tested that when this option is unset, the region defaults to us-east.

@codecov-io
Copy link

Current coverage is 51.80%

Merging #1 into master will decrease coverage by -37.48% as of f08d096

@@            master     #1   diff @@
=====================================
  Files            1      1       
  Stmts           84     83     -1
  Branches        14     14       
  Methods          0      0       
=====================================
- Hit             75     43    -32
  Partial          0      0       
- Missed           9     40    +31

Review entire Coverage Diff as of f08d096

Powered by Codecov. Updated on successful CI builds.

@flovilmart flovilmart merged commit 3d4ab56 into parse-community:master Mar 31, 2016
acinader pushed a commit to acinader/parse-server-s3-adapter that referenced this pull request Jul 1, 2017
…verride-access

Make S3Overrides accessible via E-Var or option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants