-
-
Notifications
You must be signed in to change notification settings - Fork 87
Update test.spec.js #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added tests for additional methods of passing S3 Overrides.
Hi All, |
@mrmarcsmith thanks for extending the coverage! Let's wait for the CI to finish before merging those. |
Hi @flovilmart , |
Seems that your commit didn't fix the conflicts but now it's ok |
@flovilmart this test checks pull request #37 which hasn't been approved yet. I was asked by @acinader to write this test before he would approve it. |
ah, I see. so, in your local box you should rebase (or merge) patch-2 onto patch-1 and then push it to git hub. that way the two commits will show up in the same pr and we can see the test passing. k? If you're not sure how to do, I could do for you.... |
this issue was moved to PR #40 |
Closing as moved to #40 |
added tests for additional methods of passing S3 Overrides.