Skip to content

S3 overrides as option #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2017

Conversation

mrmarcsmith
Copy link
Contributor

This is the second attempt with cleaned up code. see #40 for the old PR

Background: when using parse server with a config file there is no way to specify S3Override options.
-This change doesn't affect the current method of passing s3overrides = backwards compatible.
-s3overrides would now be accessible by via parse-server config file like this:

"filesAdapter": {
    "module":"parse-server-s3-adapter",
    "options":{
        "s3overrides": { 
            "endpoint": {
                "protocol":"https:",
                "host":"$FILEURL",
                "port":443,
                "hostname":"",
                "pathname":"/",
                "path":"/",
                "href":"https:///"
            },
            "s3BucketEndpoint": false,
            ANY OTHER S3OVERRIDES GO HERE... 
        },
        "baseUrl": "https://",
        "directAccess": true,
        "accessKey": "",
        "secretKey": "",
        "bucket": "",
        "region": ""
    }
}

@codecov
Copy link

codecov bot commented Jul 5, 2017

Codecov Report

Merging #50 into master will decrease coverage by 23.28%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #50       +/-   ##
===========================================
- Coverage   94.11%   70.83%   -23.29%     
===========================================
  Files           2        2               
  Lines         136      144        +8     
  Branches       27       31        +4     
===========================================
- Hits          128      102       -26     
- Misses          8       42       +34
Impacted Files Coverage Δ
lib/optionsFromArguments.js 95.52% <88.88%> (-1.09%) ⬇️
index.js 49.35% <0%> (-42.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 147e506...dc099b2. Read the comment docs.

@mrmarcsmith
Copy link
Contributor Author

Hi Friends! Any update on this?

@acinader acinader dismissed a stale review July 14, 2017 05:54

just going to fix the nits

@acinader acinader merged commit f1c12e6 into parse-community:master Jul 14, 2017
@acinader
Copy link
Contributor

acinader commented Jul 14, 2017

@mrmarcsmith I just pushed 1.2.0 to npm with this change. thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants