Correctly use endpoint in s3overrides #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 94.23% 94.26% +0.03%
==========================================
Files 2 2
Lines 156 157 +1
Branches 33 33
==========================================
+ Hits 147 148 +1
Misses 9 9
Continue to review full report at Codecov.
|
|
That does appear to work correctly for me now on Parse Server |
|
Can you add a test case? Here is an example https://github.com/parse-community/parse-server-s3-adapter/pull/50/files |
Apparently the constructor function exists within the Endpoint object after calling AWS.Endpoint() but not once passed through S3Adapter, but this doesn't matter anyways.
|
I think it's good now |
dplewis
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #77 . This correctly passes the endpoint override to the AWS SDK. I haven't figured out how to test this in the full parse-server yet though.