Skip to content

Commit 7af4944

Browse files
committed
revert #5627
1 parent e1ef221 commit 7af4944

File tree

5 files changed

+1
-30
lines changed

5 files changed

+1
-30
lines changed

spec/features.spec.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ describe('features', () => {
1717
expect(data).toBeDefined();
1818
expect(data.features).toBeDefined();
1919
expect(data.parseServerVersion).toBeDefined();
20-
expect(data.database).toBeDefined();
21-
expect(['MongoDB', 'PostgreSQL']).toContain(data.database.engine);
2220
});
2321

2422
it('requires the master key to get features', async done => {

src/Adapters/Storage/Mongo/MongoStorageAdapter.js

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,6 @@ export class MongoStorageAdapter implements StorageAdapter {
126126
client: MongoClient;
127127
_maxTimeMS: ?number;
128128
canSortOnJoinTables: boolean;
129-
databaseVersion: string;
130-
engine: string;
131129

132130
constructor({
133131
uri = defaults.DefaultMongoURI,
@@ -138,7 +136,6 @@ export class MongoStorageAdapter implements StorageAdapter {
138136
this._collectionPrefix = collectionPrefix;
139137
this._mongoOptions = mongoOptions;
140138
this._mongoOptions.useNewUrlParser = true;
141-
this.engine = 'MongoDB';
142139

143140
// MaxTimeMS is not a global MongoDB client option, it is applied per operation.
144141
this._maxTimeMS = mongoOptions.maxTimeMS;
@@ -962,15 +959,7 @@ export class MongoStorageAdapter implements StorageAdapter {
962959
}
963960

964961
performInitialization(): Promise<void> {
965-
// databaseVersion
966-
return this.connect()
967-
.then(() => {
968-
const adminDb = this.database.admin();
969-
return adminDb.serverStatus();
970-
})
971-
.then(status => {
972-
this.databaseVersion = status.version;
973-
});
962+
return Promise.resolve();
974963
}
975964

976965
createIndex(className: string, index: any) {

src/Adapters/Storage/Postgres/PostgresStorageAdapter.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -778,8 +778,6 @@ const buildWhereClause = ({ schema, query, index }): WhereClause => {
778778

779779
export class PostgresStorageAdapter implements StorageAdapter {
780780
canSortOnJoinTables: boolean;
781-
databaseVersion: string;
782-
engine: string;
783781

784782
// Private
785783
_collectionPrefix: string;
@@ -792,7 +790,6 @@ export class PostgresStorageAdapter implements StorageAdapter {
792790
this._client = client;
793791
this._pgp = pgp;
794792
this.canSortOnJoinTables = false;
795-
this.engine = 'PostgreSQL';
796793
}
797794

798795
handleShutdown() {
@@ -2279,12 +2276,6 @@ export class PostgresStorageAdapter implements StorageAdapter {
22792276
})
22802277
.then(data => {
22812278
debug(`initializationDone in ${data.duration}`);
2282-
// databaseVersion
2283-
return this._client.query('SHOW server_version');
2284-
})
2285-
.then(versionData => {
2286-
// versionData is like [ { server_version: '11.3' } ]
2287-
this.databaseVersion = versionData[0].server_version;
22882279
})
22892280
.catch(error => {
22902281
/* eslint-disable no-console */

src/Adapters/Storage/StorageAdapter.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ export type FullQueryOptions = QueryOptions & UpdateQueryOptions;
2525

2626
export interface StorageAdapter {
2727
canSortOnJoinTables: boolean;
28-
databaseVersion: string;
29-
engine: string;
3028

3129
classExists(className: string): Promise<boolean>;
3230
setClassLevelPermissions(className: string, clps: any): Promise<void>;

src/Routers/FeaturesRouter.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,10 @@ export class FeaturesRouter extends PromiseRouter {
5252
},
5353
};
5454

55-
const dbAdapter = config.database.adapter;
5655
return {
5756
response: {
5857
features: features,
5958
parseServerVersion: version,
60-
database: {
61-
engine: dbAdapter.engine,
62-
version: dbAdapter.databaseVersion,
63-
},
6459
},
6560
};
6661
}

0 commit comments

Comments
 (0)