Database version in features #5627
Conversation
…efined when using Postgres)
. adding engine and database in the StorageAdapter interface and implementations
Codecov Report
@@ Coverage Diff @@
## master #5627 +/- ##
==========================================
+ Coverage 94.13% 94.16% +0.03%
==========================================
Files 129 129
Lines 9235 9244 +9
==========================================
+ Hits 8693 8705 +12
+ Misses 542 539 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks good, just a few changes from me.
{"version":"${MONGODB_VERSION:=4.0.4}","arch":"x86_64","platform":"win32","branch":"master","bits":"64","de bug":false,"ext":".zip","distro":"2008plus-ssl","filenamePlatform":"win32"}
Is a windows issue to resolve install mongodb 4.0.4.
If not you can change package.json
from
"test": "cross-env MONGODB_VERSION=${MONGODB_VERSION:=4.0.4} MONGODB_STORAGE_ENGINE=mmapv1 TESTING=1 jasmine",
to the following temporarily and run your own mongodb locally (if you do, don't commit it)
cross-env TESTING=1 jasmine
|
@dplewis I checked "Resolve Conversation" . I don't know if I can do it or if you prefer to do it. |
|
Thanks for the PR. Maybe we can get this in the Dashboard. |
|
or in the REST doc :) |
|
I've started the dashboard thing. |
ghost
mentioned this pull request
* adding database.version in the serverInfo (only MongoDB, it gives undefined when using Postgres) * . correction of old 'features' tests . adding engine and database in the StorageAdapter interface and implementations * . version retrieval done in performInitialization . PostgreSQL version * performInitialization now returns a Promise
* Fix parse-community#5678 * Revert "Fix parse-community#5678" This reverts commit 106b6dd. * revert parse-community#5627
I added databaseVersion and engine in serverInfo (and in StorageAdapter).
I also corrected the old test (it failed apparently).
Note that I installed a local MongoDB. The features.spec.js tests pass with no error, but I still get a "Top Level suite" error:
Could not find a MongoDB version matching
{"version":"${MONGODB_VERSION:=4.0.4}","arch":"x86_64","platform":"win32","branch":"master","bits":"64","de bug":false,"ext":".zip","distro":"2008plus-ssl","filenamePlatform":"win32"}