Adding Sentry exception logging to Parse server #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not in love with the implementation... Maybe you could abstract out a LogAdapter instead, and have it be a module you inject. |
|
Sure, thanks for the tip. Looks like I have some weekend coding. ☕ |
Closed
|
Could you point me to an example in the code of a similar abstraction? |
|
I'd say look at FilesAdapter and GridStoreAdapter.. let me know if you have questions. |
|
A logging adapter will be added in #243 and you can build a Sentry adapter for that. Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to also provide documentation on spinning up the open source Sentry server, for those wanting to run that themselves as well.