Add additional default fields to _Installation class #1852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fields are appVersion, appName, appIdentifier, and parseVersion. These fields are sent by Android and iOS SDKs.
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _Installation class was missing default fields for
appVersion,appName,appIdentifier, andparseVersion.When I disabled
addFieldclass level permissions for _Installation class, iOS and Android SDKs were getting "Permission denied for this action." when creating installations because they send the above fields.Also, I updated
Schema.spec.jsandMongoSchemaCollectionAdapter.spec.jsto account for all default _Installtion fields.