Skip to content

Incorporate vitaly-t changes #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2016
Merged

Conversation

drew-gross
Copy link
Contributor

@vitaly-t this is the replacement PR. Everything looks good to me. Thanks for the help! Tests already passed on the original PR so I will merge right away.

@drew-gross drew-gross merged commit c37a4ea into parse-community:master Jun 17, 2016
@drew-gross drew-gross deleted the vitaly-t branch June 17, 2016 02:34
@vitaly-t
Copy link
Contributor

@drew-gross

I don't know the role of this piece of code, but does it need performance and efficiency, or those are not important in this context?

I'm asking to see what other improvements might be worthwhile adding, because on the overall there could be too many ;)

@drew-gross
Copy link
Contributor Author

Cool! This is definitely a performance-critical part of the system. getClass, updateObjectsByQuery, and deleteObjectsByQuery are probably the most critical. Of course, there are still many unimplemented parts, so until those are implemented there won't be much benefit in making stuff faster.

@vitaly-t
Copy link
Contributor

vitaly-t commented Jun 17, 2016

Great! Let me know if you have any questions, I will be happy to help!

In the meantime, the biggest omission I've seen in the code is in trying to generate inserts and updates manually, not automatically with methods in the helpers namespace, which is exactly what it was implemented for ;)

That namespace lets you generate inserts and updates much faster, simpler and more reliably ;)

It is especially helpful in generating multi-row inserts and updates ;)

@vitaly-t
Copy link
Contributor

vitaly-t commented Jun 17, 2016

P.S. Although, if it already works, then it's not that important, just for the future ;)

And just so, a shorter form for :name format is simply ~ ;) and ^ is short version for :raw ;)

@drew-gross
Copy link
Contributor Author

That looks really useful, I will check out the helpers namespace. Awesome.

I prefer the long-form names, actually. Otherwise you can end up with strings of like 10 symbols in a row, which I think is harder to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants