Update PostgresStorageAdapter.js #2087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, do not use
.catch
before.then
. It is dangerous without good understanding how it actually works:if you do not throw an error in
.catch
or return a rejected promise explicitly, you will get in the following.then
with whatever value that was returned.Check this out:
This is why it is always best to have
.catch
at the bottom, though the logic changes ;)