Improve error message for Parse.Error.INCORRECT_TYPE failure condition #2185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Would you mind writing a test to make sure we don't have a regression? Are we sure type is always an object? |
|
I'm ignorant as to how to write a test (sorry). However, I believe we can be 100% confident that type is an object based on how it's used in the dbTypeMatchesObjectType method. |
|
Ok, seems good to me then. Thanks for the contribution. |
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Mar 15, 2017
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the error message looks like the following, which needs improvement.
schema mismatch for _User.nebulousDataType; expected Number but got [object Object]