-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Adds redis cache for distributed environments #2691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is 92.31% (diff: 100%)@@ master #2691 diff @@
==========================================
Files 102 103 +1
Lines 12449 12539 +90
Methods 1559 1583 +24
Messages 0 0
Branches 2039 2043 +4
==========================================
+ Hits 11486 11576 +90
Misses 963 963
Partials 0 0
|
@flovilmart updated the pull request - view changes |
2649bc8
to
621740b
Compare
@flovilmart updated the pull request - view changes |
Also sets the PG tests to allow failure until we figure out good repro steps, at least the history will be kept in travis, and build won't fail for bad reasons. |
Can you add some docs for this one as well? |
On the wiki yes! |
@flovilmart adding support for caching on the server is great. Thanks |
This isn't for cloud code, this is for the internal cache. |
621740b
to
fce4601
Compare
@flovilmart updated the pull request - view changes |
Is there any way you suggest to use some type of caching in cloud code. |
You would have to use cloud functions for that. |
Right, but do you have any suggestion for how to cache the data in cloud function over future calls. I can create something from scratch, but I am sure their is already good other solution that other used, as this should be a common need by many to improve performance. |
Again, that is not the purpose of that adapter. it's only purpose is the same as the original InMemoryCacheAdapter. For other caching mechanisms you should not use that, as we internally flush the cache entirely. |
I understand that I should not use it. My question was do you have advise about another cache mechanism I can use in cloud code that will be persistent as long the server is up? If server is restarted I will rebuild the cache from scratch. |
You should probably as those questions over stackoverflow or stackexchange. I have no suggestion for building such cache as it depends on many parameters. |
Cool. I see the docs now. @mmarshak since Cloud Code in |
@drew-gross thank you for the pointers. |
No description provided.