Adding support for AfterFind #2962
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide certain fields or rows from result set in a more dynamic way than the current capabilities
|
5a58724#diff-dc168077f7f927cefd5df84cb82228a6R481 variable name should be hasAfterFindHook - not hasAfterSaveHook |
flovilmart
suggested changes
Oct 30, 2016
| @@ -640,4 +660,7 @@ function findObjectWithKey(root, key) { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
| }; | ||
| logTriggerSuccessBeforeHook(triggerType, className, 'AfterFind', JSON.stringify(results), auth); | ||
| var resultsAsParseObjects = []; | ||
| for (var i=0;i<results.length;i++){ |
There was a problem hiding this comment.
You should use a map here. We avoid for loops with indexes
| response.results = resultsAsParseObjects; | ||
| var triggerPromise = trigger(request, response); | ||
| var modifiedJSONResults = []; | ||
| for(var i = 0;i<response.results.length;i++){ |
| for(var i = 0;i<response.results.length;i++){ | ||
| modifiedJSONResults.push(response.results[i].toJSON()); | ||
| } | ||
| logTriggerAfterHook(triggerType,className, JSON.stringify(modifiedJSONResults), auth); |
| }); | ||
| }); | ||
|
|
||
| }); |
| } | ||
| logTriggerAfterHook(triggerType,className, JSON.stringify(modifiedJSONResults), auth); | ||
| if (triggerPromise && typeof triggerPromise.then === "function") { | ||
| return reject(new Parse.Error(Parse.Error.SCRIPT_FAILED, "Promise not supported by AfterFind")); |
There was a problem hiding this comment.
Because the beforeFind trigger uses promises, and promises are more convenient that the callback, we should put it there too
* Close all alive connections on SIGINT/SIGTERM * Add a comment referencing the node issue.
Currently in the logs if an invalid function is called the error message just says "invalid function" which is decidedly unhelpful when looking through server logs. Now it will say "Invalid function: "functionName""
…ide certain fields or rows from result set in a more dynamic way than the current capabilities
|
@jbpringuey updated the pull request - view changes |
|
messed up the rebase, it is showing other's commit too let me try to fix it |
…ide certain fields or rows from result set in a more dynamic way than the current capabilities
* Close all alive connections on SIGINT/SIGTERM * Add a comment referencing the node issue.
Currently in the logs if an invalid function is called the error message just says "invalid function" which is decidedly unhelpful when looking through server logs. Now it will say "Invalid function: "functionName""
|
@jbpringuey updated the pull request - view changes |
|
going to resubmit ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security reasons, I need to hide certain fields (like email) and rows from the API for use cases which are not supported by the current ACL framework. This plugin will enable all sorts of manipulation. Next step would be to support promise to maybe augment the response from other data source.