Skip to content

Don't create default folder when PARSE_SERVER_LOGS_FOLDER is null or "null" #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

steven-supersolid
Copy link
Contributor

While 'null' works for the logger adapter created in ParseServer.js, it does not work for the default logger that is created in logger.js.

E.g. currently if the following is set

export PARSE_SERVER_LOGS_FOLDER="null"

Then a folder with the name null is created.

@flovilmart
Copy link
Contributor

Then a folder with the name null is created.

yeah the CLI is not nice, but if you put export PARSE_SERVER_LOGS_FOLDER= 

what does it do?

@steven-supersolid
Copy link
Contributor Author

In that case the behaviour is the same with this code as master in that a folder named logs is created by default and the same folder is used by the non-default logger.

On Heroku I don't think it's possible to set an empty environment variable so the string null is useful.

Currently I'm using express mounted and passing a config option logsFolder: null but actually that doesn't avoid creating a folder either as defaults.js is still looking for the environment variable.

@flovilmart flovilmart merged commit bb9ce77 into parse-community:master Nov 4, 2016
@steven-supersolid steven-supersolid deleted the steven.null.logs.folder branch June 23, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants