Improvements to CLI parsers #3034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…message in numberParser. Add env variable PARSE_SERVER_CLUSTER for cluster. Add tests
|
LGTM! Thanks!
Yes they are, it's an array of strings that commander gets. |
|
OK so is there any point parsers doing type checking or checking for non-string values? Happy to clean up as part of this PR |
|
uhmmm, I believe the parsers are used for json/js config files, but I'm not sure |
TylerBrock
approved these changes
Nov 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow numberOrBooleanParser to parse a string correctly so
parse-server -cluster truewill now work. In a quick test, all cli options are typed as strings, e.g. null, true, 2. Not sure if this is platform/nodejs version specific though.Improve error message in numberParser, e.g.
parse-server -cluster failwill beKey cluster has invalid value failinstead ofThe cluster is invalidAdd env variable PARSE_SERVER_CLUSTER for cluster, because we want to set this per environment.
Added some basic tests to clarify existing parser behavior.