Enhanced support for batch endpoints #3042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
changed the title
|
@flovilmart updated the pull request - view changes |
steven-supersolid
approved these changes
Nov 24, 2016
| } | ||
|
|
||
| function mBatchRoutingPath(originalUrl, serverURL, publicServerURL) { | ||
| serverURL = serverURL ? parseURL(serverURL) : undefined; |
There was a problem hiding this comment.
minor but could you just move the check for URL being defined into parseURL? e.g. change in the function to if (URL && typeof URL === 'string') {
| return undefined; | ||
| } | ||
|
|
||
| function mBatchRoutingPath(originalUrl, serverURL, publicServerURL) { |
There was a problem hiding this comment.
nit: is m short for make? Prefer explicit function names for clarity
| if (requestPath.slice(0, apiPrefixLength) != apiPrefix) { | ||
| throw new Parse.Error( | ||
| Parse.Error.INVALID_JSON, | ||
| 'cannot route batch path ' + path); |
There was a problem hiding this comment.
I think path here will point to the require. Should be requestPath?
|
|
||
| let makeRoutablePath = function(requestPath) { | ||
| // The routablePath is the path minus the api prefix | ||
| if (requestPath.slice(0, apiPrefixLength) != apiPrefix) { |
There was a problem hiding this comment.
minor: could replace apiPrefixLength with apiPrefix.length here and on line 35 and then remove line 44
flovilmart
force-pushed
the
issue-#2980
branch
from
a30423d to
e5f1bd0
Compare
|
@flovilmart updated the pull request - view changes |
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Dec 3, 2016
* Allow to have different endpoint on publicserverURL and serverURL when batching * nits
Jcarlosjunior
pushed a commit
to back4app/parse-server
that referenced
this pull request
Dec 13, 2016
* Allow to have different endpoint on publicserverURL and serverURL when batching * nits
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to have publicServerURL different from serverURL ex:
http://api.my-parse.com/andhttp://localhost/parsefor batch callsFixes #2980