add login with qq, wechat and weibo #3069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
suggested changes
Nov 21, 2016
| @@ -33,7 +36,10 @@ let providers = { | |||
| digits, | |||
| janrainengage, | |||
| janraincapture, | |||
| vkontakte | |||
| vkontakte, | |||
| qq:qq, | |||
There was a problem hiding this comment.
pleas use the short hand like the others
| function graphRequest(path) { | ||
| return new Promise(function (resolve, reject) { | ||
|
|
||
|
|
| }).on('error', function (e) { | ||
| reject('Failed to validate this access token with qq.'); | ||
| }); | ||
|
|
|
|
||
| function graphRequest(path) { | ||
| return new Promise(function (resolve, reject) { | ||
|
|
| }).on('error', function (e) { | ||
| reject('Failed to validate this access token with weixin.'); | ||
| }); | ||
|
|
| "access_token":access_token | ||
| }); | ||
|
|
||
| var options = { |
| } | ||
| }; | ||
|
|
||
| var req = https.request(options, function(res){ |
| var data = ''; | ||
| res.on('data', function (chunk) { | ||
| data += chunk; | ||
| }); |
| }); | ||
| req.write(postData); | ||
| req.end(); | ||
|
|
| module.exports = { | ||
| validateAppId: validateAppId, | ||
| validateAuthData: validateAuthData | ||
| }; |
There was a problem hiding this comment.
use short hands and add line break
|
@qiushi2012 updated the pull request - view changes |
flovilmart
approved these changes
Nov 22, 2016
|
Thanks! This all seems to be ok now! |
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Dec 3, 2016
* add login with qq, wechat and weibo * modify the code style, etc
Jcarlosjunior
pushed a commit
to back4app/parse-server
that referenced
this pull request
Dec 13, 2016
* add login with qq, wechat and weibo * modify the code style, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add login with qq, wechat and weibo