use uWS as optional dependency for ws server #3231
Conversation
| var parseWebSocketServer = new ParseWebSocketServer({}, onConnectCallback, 5).server; | ||
| var http = require('http'); | ||
| var server = http.createServer(); | ||
| var parseWebSocketServer = new ParseWebSocketServer(server, onConnectCallback, 5).server; |
There was a problem hiding this comment.
needed to add that as the uWS implementation call .on when the server is created.
There was a problem hiding this comment.
Hi @flovilmart i noticed that uws was not part of the latest release...
| @@ -1,12 +1,20 @@ | |||
| import logger from '../logger'; | |||
|
|
|||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
what are you disabling?
is it just the next line? if so, use:
// eslint-disable-next-line foo
otherwise, reenable where it makes sense
also put the specific rule you're trying to turn off?
|
oh, and sweet. |
|
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @greenkeeperio-bot as a potential reviewer. Could you take a look please or cc someone with more context? |
|
@flovilmart updated the pull request - view changes |
|
@flovilmart updated the pull request - view changes |
|
@acinader addressed the nits |
As per #3221, uWS is a highly optimized web socket server, that outperforms many other implementations.
The uWS server is an optional dependency so if it can't build, this will fallback to original ws implementation.