Skip to content

Add install instructions for root user #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2017

Conversation

zeekhuge
Copy link
Contributor

I am a not a nodejs developer, and it took a lot of time to figure this out.
Hope this commit will help others.

@TylerBrock
Copy link
Contributor

Thanks for contributing, it's actually not the case that the root user has to be the one running the command. It depends on how your node is configured. Perhaps you could re-word the comment to say something to the effect of "Run this command with a user having enough privilege to install global modules"

@facebook-github-bot
Copy link

@zeekhuge updated the pull request - view changes

@zeekhuge
Copy link
Contributor Author

zeekhuge commented Feb 4, 2017

Did as per your instructions.
Thanks

@acinader
Copy link
Contributor

acinader commented Feb 11, 2017

@TylerBrock @zeekhuge

I was just looking at this to see why it is still open and if there is anything I could do to move the ball forward. So now that I have researched it, I don't think this is what we want to add.

@zeekhuge I think that this link (https://docs.npmjs.com/getting-started/fixing-npm-permissions) covers the issue you ran into and the "right" solution. To @TylerBrock's point, we don't want to be recommending that anyone run npm as root (or sudo), and if npm is properly configured, then --unsafe-perm is unnecessary.

So I'd think that we either a) change the comment to something like: If you have a permission problem when installing with -g see this link (and link to the link above). or b) just leave as is and close this pr?

@zeekhuge what do you think?

@TylerBrock
Copy link
Contributor

Can we get an update on this one @zeekhuge? We'd love for the instructions to be more clear and want to move forward. If we don't hear from you for a week we will close it out.

@zeekhuge
Copy link
Contributor Author

@TylerBrock @acinader

Sorry, for replying back late, was busy with exams.
So, after what @acinader suggested, I think we should mention the solution in comments (i.e. option (a)).

I will update the PR.
Thanks for help.

@facebook-github-bot
Copy link

@zeekhuge updated the pull request - view changes

Commit adds a reference to solve the EACCES error while installation.
@facebook-github-bot
Copy link

@zeekhuge updated the pull request - view changes

@facebook-github-bot
Copy link

@zeekhuge I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@zeekhuge
Copy link
Contributor Author

@TylerBrock If you could please review this request or close it if its no longer required.

@facebook-github-bot
Copy link

@zeekhuge updated the pull request - view changes

@facebook-github-bot
Copy link

@zeekhuge updated the pull request - view changes

@acinader acinader merged commit a54f4d4 into parse-community:master Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants