removing inline sql. #3529
removing inline sql. #3529
Conversation
|
Build fails because of indentation in file sql/index.js. How can I fix it in WebStorm? |
trying to fix indentation.
|
@vitaly-t updated the pull request - view changes |
commenting out console output for errors.
|
@vitaly-t updated the pull request - view changes |
| @@ -25,7 +25,8 @@ function sql(file) { | |||
| var qf = new QueryFile(fullPath, {minify: true}); | |||
|
|
|||
| if (qf.error) { | |||
| console.error(qf.error); | |||
| // commented out because Lint doesn't permit console messages: | |||
| // console.error(qf.error); | |||
There was a problem hiding this comment.
if we can't parse a query file, we should probably throw and exit :)
There was a problem hiding this comment.
Otherwise that looks great!
There was a problem hiding this comment.
this one was done.
|
@vitaly-t updated the pull request - view changes |
|
Renamed one file, which was named by mistake. |
|
@vitaly-t updated the pull request - view changes |
correcting sql.
|
@vitaly-t updated the pull request - view changes |
correcting sql.
correcting sql.
correcting sql.
|
@vitaly-t updated the pull request - view changes |
|
@vitaly-t updated the pull request - view changes |
correcting sql.
fixing sql reserved words.
|
@vitaly-t updated the pull request - view changes |
|
@vitaly-t updated the pull request - view changes |
|
@vitaly-t updated the pull request - view changes |
|
@vitaly-t updated the pull request - view changes |
|
@flovilmart it is now ready to be merged. |
|
Build was successful, please merge it ;) |
|
Looking awesome thanks!! |
Started moving SQL outside. There can be plenty of improvements added after this one is merged.