Add support for resending verification email in case of expired token #3617

cmmills91 · 2017-03-11T01:40:07Z

Defines new public API route /apps/:appId/resend_verification_email that will generate a new email verification link and email for a user identified by username in POST body
Add default template and url support for invalid_verification_link, link_send_success, and link_send_fail pages. The invalid_verification_link page includes a button that allows the user to generate a new verification email if their current token has expired, using the new public API route
All three pages have default html that will be functional "out of the box", but they can be customized in the customPages object. The custom page for invalidVerificationLink needs to handle the extraction of the username and appId from the url and the POST to generate the new link (this requires javascript)
Clicking a link for an email that has already been verified now routes to the emailVerifySuccess page instead of the invalidLink page

…that will generate a new email verification link and email for a user identified by username in POST body -Add template and url support for invalidVerificationLink, linkSendSuccess, and linkSendFail pages. The invalidVerificationLink pages includes a button that allows the user to generate a new verification email if their current token has expired, using the new public API route -All three pages have default html that will be functional out of the box, but they can be customized in the customPages object. The custom page for invalidVerificationLink needs to handle the extraction of the username and appId from the url and the POST to generate the new link (this requires javascript) -Clicking a link for an email that has already been verified now routes to the emailVerifySuccess page instead of the invalidLink page

Implementation for allowing link resend when it's invalid.

flovilmart · 2017-03-13T13:00:47Z

@cmmills91 Thanks for the great pull request! Love that feature! Can you address the issues with the lint?

> [email protected] lint /home/travis/build/ParsePlatform/parse-server
> eslint --cache ./
/home/travis/build/ParsePlatform/parse-server/src/Controllers/UserController.js
   68:8   error  Trailing spaces not allowed      no-trailing-spaces
  151:84  error  'res' is defined but never used  no-unused-vars

you can run locally with npm test or npm run lint

I'll start the review after!

facebook-github-bot · 2017-03-13T21:27:04Z

@cmmills91 updated the pull request - view changes

cmmills91 · 2017-03-13T21:47:56Z

Should I adjust unit tests as well? Looks like they're making CI tests fail

flovilmart · 2017-03-13T21:51:05Z

Yup seems like some tests are failing now: https://travis-ci.org/ParsePlatform/parse-server/jobs/210725165#L838

facebook-github-bot · 2017-03-13T22:37:00Z

@cmmills91 updated the pull request - view changes

facebook-github-bot · 2017-03-13T22:37:01Z

@cmmills91 updated the pull request - view changes

flovilmart · 2017-03-14T13:42:59Z

public_html/invalid_verification_link.html

@@ -0,0 +1,68 @@
+<!DOCTYPE html>
+<!-- This page is displayed when someone navigates to a verify email or reset password link


not sure we should keep those comments, when serving the files

Do you mean removing the comments from the html file entirely or is there some kind of general solution the can remove comments from the file before being sent back?

The existing invalid_link.html file already has similar set of comments (in fact, the exact same comments that appear in these files since I just copied over the contents of invalid_link and made a few alterations 😅 )

I'm going to edit the comments on the pages to be more relevant though

flovilmart · 2017-03-14T13:43:21Z

spec/EmailVerificationToken.spec.js

@@ -359,7 +359,7 @@ describe("Email Verification Token Expiration: ", () => {
        followRedirect: false,
      }, (error, response) => {
        expect(response.statusCode).toEqual(302);
-        expect(response.body).toEqual('Found. Redirecting to http://localhost:8378/1/apps/invalid_link.html');
+        expect(response.body).toEqual('Found. Redirecting to http://localhost:8378/1/apps/verify_email_success.html?username=testEmailVerifyTokenValidity');


not sure we should change that page.

I think it makes more sense to direct a user that page than the invalid_link or invalid_verification_link page. I made the change based on clicking on a few verification links in my inbox (that I had already verified) and more than half of them did showed the success page (small sample size though)

flovilmart · 2017-03-14T13:48:25Z

src/Controllers/UserController.js

@@ -134,6 +141,19 @@ export class UserController extends AdaptableController {
    });
  }

+  resendVerificationEmail(username) {
+    var self = this;


no need for self, if you're using arrow functions.

flovilmart · 2017-03-14T13:50:47Z

src/Controllers/UserController.js

+        throw undefined;
+      }
+      self.setEmailVerifyToken(aUser);
+      return self.config.database.update('_User', {username}, aUser).then(function() {


replace function() by () => and remove self

flovilmart · 2017-03-14T13:52:07Z

src/Routers/PublicAPIRouter.js

+    if (req.query.username && req.params.appId) {
+      return Promise.resolve({
+        status: 302,
+        location: req.config.invalidVerificationLinkURL + '?username=' + req.query.username + '&appId=' + req.params.appId


can we use a template string?

flovilmart · 2017-03-14T13:52:39Z

src/Routers/PublicAPIRouter.js

@@ -140,6 +179,10 @@ export class PublicAPIRouter extends PromiseRouter {
      req => { this.setConfig(req) },
      req => { return this.verifyEmail(req); });

+    this.route('POST', '/apps/:appId/resend_verification_email',
+      req => {this.setConfig(req) },


space beween { and this

add ; after this.setConfig(req)

flovilmart · 2017-03-14T13:53:44Z

src/Controllers/UserController.js

-    return this.config.database.update('_User', query, updateFields).then((document) => {
-      if (!document) {
-        throw undefined;
+    var self = this;


remove self, and replace function() by () => (arrow functions)

flovilmart · 2017-03-16T03:21:18Z

I just had a few nits here and there, otherwise that looks great!

…emplate to construct location for invalidVerificationLink page, syntax fixes

facebook-github-bot · 2017-03-17T21:05:25Z

@cmmills91 updated the pull request - view changes

facebook-github-bot · 2017-03-20T01:11:28Z

@cmmills91 updated the pull request - view changes

flovilmart · 2017-03-17T21:12:24Z

public_html/link_send_fail.html

+<!-- This page is displayed when someone navigates to a verify email link with an invalid
+     security token and requests a link resend. This page is displayed when the username from
+     the original link is invalid or if the email of that user has already been verfieid when
+     the resend request is made


Small typo 'verified'

flovilmart · 2017-05-10T13:02:34Z

@cmmills91 sorry for the delay to get that one in, thanks for your contribution!

Cody Mills and others added 3 commits March 10, 2017 15:23

Merge pull request #1 from LoungeBuddy/invalid_verify_link

b1386e3

Implementation for allowing link resend when it's invalid.

Fix package.json repo url to be parse-server againwq

2755f8e

facebook-github-bot added the GH Review: review-needed label Mar 11, 2017

cmmills91 changed the title ~~Support for resending verification email in case of expired token~~ Add support for resending verification email in case of expired token Mar 13, 2017

Fix js lint issues

fbfece2

Update unit tests

c8d561c

flovilmart reviewed Mar 14, 2017

View reviewed changes

flovilmart suggested changes Mar 16, 2017

View reviewed changes

Use arrow functions, change html page comments, use qs and a string t…

741c2c4

…emplate to construct location for invalidVerificationLink page, syntax fixes

Remember to pass result when using arrow function

5c61a16

flovilmart approved these changes May 10, 2017

View reviewed changes

flovilmart merged commit 22ba398 into parse-community:master May 10, 2017

		@@ -0,0 +1,68 @@
		<!DOCTYPE html>
		<!-- This page is displayed when someone navigates to a verify email or reset password link

Uh oh!

Add support for resending verification email in case of expired token #3617

Add support for resending verification email in case of expired token #3617

Uh oh!

Conversation

cmmills91 commented Mar 11, 2017

Uh oh!

flovilmart commented Mar 13, 2017

Uh oh!

facebook-github-bot commented Mar 13, 2017

Uh oh!

cmmills91 commented Mar 13, 2017

Uh oh!

flovilmart commented Mar 13, 2017

Uh oh!

facebook-github-bot commented Mar 13, 2017

Uh oh!

facebook-github-bot commented Mar 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flovilmart commented Mar 16, 2017

Uh oh!

facebook-github-bot commented Mar 17, 2017

Uh oh!

facebook-github-bot commented Mar 20, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flovilmart commented May 10, 2017

Uh oh!

Uh oh!